Bug 108910

Summary: touch-event.html should check touchstartFiredInShadowDOM is true.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: hayato, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107796    
Attachments:
Description Flags
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2013-02-04 23:06:27 PST
Maybe I forgot to check touchstartFiredInShadowDOM in touch-event.html. We definitely check it.
Attachments
Patch (1.98 KB, patch)
2013-02-04 23:10 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.06 KB, patch)
2013-02-05 00:40 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2013-02-04 23:10:26 PST
Created attachment 186554 [details] Patch
Hayato Ito
Comment 2 2013-02-05 00:00:46 PST
Unofficial rs=me on this. Looks okay to me since this fixes a trivial mistake on the layout test committed previously. Note that there are still cases where touch events are not fired on shadow tree. See bug 108908.
Hajime Morrita
Comment 3 2013-02-05 00:16:08 PST
Comment on attachment 186554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review > LayoutTests/ChangeLog:8 > + We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM. This looks like a followup patch. Could you refer the original revision?
Shinya Kawanaka
Comment 4 2013-02-05 00:40:10 PST
Created attachment 186564 [details] Patch for landing
Shinya Kawanaka
Comment 5 2013-02-05 00:40:33 PST
(In reply to comment #3) > (From update of attachment 186554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review > > > LayoutTests/ChangeLog:8 > > + We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM. > > This looks like a followup patch. Could you refer the original revision? Sure.
WebKit Review Bot
Comment 6 2013-02-05 01:07:08 PST
Comment on attachment 186564 [details] Patch for landing Clearing flags on attachment: 186564 Committed r141869: <http://trac.webkit.org/changeset/141869>
WebKit Review Bot
Comment 7 2013-02-05 01:07:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.