Bug 108377

Summary: [HTMLTemplateElement] prevent the parser from removing nodes from the content when the foster agency is processing formatting elements
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: DOMAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, eric, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103547    
Attachments:
Description Flags
Patch
none
Patch none

Rafael Weinstein
Reported 2013-01-30 14:05:52 PST
https://www.w3.org/Bugs/Public/show_bug.cgi?id=20829
Attachments
Patch (5.48 KB, patch)
2013-01-30 14:11 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (6.96 KB, patch)
2013-01-30 14:31 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2013-01-30 14:11:05 PST
Created attachment 185562 [details] Patch
Adam Klein
Comment 2 2013-01-30 14:29:12 PST
Comment on attachment 185562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185562&action=review > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1592 > + if (commonAncestor->hasTagName(templateTag)) Wouldn't it be nice if we could just do this check inside parserAppendChild? We probably don't want to do this for performance reasons, but we could at least add an ASSERT that the parser never appends directly to <template>. Sort of weird to have an assertion about HTML parsing behavior in ContainerNode.cpp, but then parserAppendChild is effectively part of the HTML parser anyway.
Rafael Weinstein
Comment 3 2013-01-30 14:30:35 PST
Comment on attachment 185562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185562&action=review >> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1592 >> + if (commonAncestor->hasTagName(templateTag)) > > Wouldn't it be nice if we could just do this check inside parserAppendChild? We probably don't want to do this for performance reasons, but we could at least add an ASSERT that the parser never appends directly to <template>. Sort of weird to have an assertion about HTML parsing behavior in ContainerNode.cpp, but then parserAppendChild is effectively part of the HTML parser anyway. done
Rafael Weinstein
Comment 4 2013-01-30 14:31:35 PST
Created attachment 185576 [details] Patch
Adam Barth
Comment 5 2013-01-30 14:34:21 PST
Comment on attachment 185576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185576&action=review > LayoutTests/html5lib/resources/template.dat:946 > +<body><template><i><menu>Foo</i> Not really related to this patch, but do you have commit rights to the html5lib codesite project?
Rafael Weinstein
Comment 6 2013-01-30 14:36:38 PST
no. that'd be nice =-).
WebKit Review Bot
Comment 7 2013-01-30 15:13:25 PST
Comment on attachment 185576 [details] Patch Clearing flags on attachment: 185576 Committed r141327: <http://trac.webkit.org/changeset/141327>
WebKit Review Bot
Comment 8 2013-01-30 15:13:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.