Bug 107806

Summary: [EFL][WK2] Use C API inside ewk_auth_request
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, gyuyoung.kim, kenneth, kling, lucas.de.marchi, mikhail.pozdnyakov, naginenis, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107657    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2013-01-24 02:55:19 PST
As per Bug 107657, we should start using the C API internally to avoid violating layering.
Attachments
Patch (10.55 KB, patch)
2013-01-24 03:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.51 KB, patch)
2013-01-28 11:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.13 KB, patch)
2013-01-29 11:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-24 03:26:31 PST
Created attachment 184456 [details] Patch
Chris Dumez
Comment 2 2013-01-28 11:11:25 PST
Created attachment 185015 [details] Patch Rebased on master. Could someone please review?
Chris Dumez
Comment 3 2013-01-29 11:56:16 PST
Created attachment 185277 [details] Patch Simplify the patch a little. No longer requires any new C API.
Kenneth Rohde Christiansen
Comment 4 2013-02-01 04:18:19 PST
Comment on attachment 185277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185277&action=review LGTM > Source/WebKit2/ChangeLog:11 > + classes directly, to avoid violating layering. > + > + * UIProcess/API/efl/ewk_auth_request.cpp: You probably want to add something like: Refactoring only, tested by existing tests
WebKit Review Bot
Comment 5 2013-02-01 04:57:50 PST
Comment on attachment 185277 [details] Patch Clearing flags on attachment: 185277 Committed r141581: <http://trac.webkit.org/changeset/141581>
WebKit Review Bot
Comment 6 2013-02-01 04:57:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.