Bug 107693

Summary:

[WK2][EFL] Remove unneeded private methods

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit2

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, gyuyoung.kim, kalyan.kondapally, laszlo.gombos, mikhail.pozdnyakov, ostap73, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107657

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Kenneth Rohde Christiansen

Reported 2013-01-23 07:48:05 PST

Remove two unneeded private methods in EwkViewImpl as we are trying to slim the class somewhat and later split it up.

Attachments
Patch (4.03 KB, patch) 2013-01-23 07:49 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Patch (3.37 KB, patch) 2013-01-24 02:57 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Patch (3.90 KB, patch) 2013-01-28 02:04 PST, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kenneth Rohde Christiansen

Comment 1 2013-01-23 07:49:53 PST

Created attachment 184234 [details] Patch

Mikhail Pozdnyakov

Comment 2 2013-01-23 10:28:01 PST

Comment on attachment 184234 [details] Patch looks nice.

Mikhail Pozdnyakov

Comment 3 2013-01-23 10:29:49 PST

Comment on attachment 184234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review > Source/WebKit2/ChangeLog:3 > + [WK][EFL] Remove unneeded private methods [WK2] ?

Benjamin Poulain

Comment 4 2013-01-23 14:54:22 PST

Comment on attachment 184234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:380 > + if (m_pendingSurfaceResize || !m_evasGLSurface) { The way the state is handled before coming here is madness. I am not sure you even need "|| !m_evasGLSurface". I think some clarifying of the state would be beneficial.

Kenneth Rohde Christiansen

Comment 5 2013-01-24 02:57:02 PST

Created attachment 184452 [details] Patch

Kalyan

Comment 6 2013-01-24 02:59:01 PST

LGTM.

Benjamin Poulain

Comment 7 2013-01-24 14:12:14 PST

Comment on attachment 184452 [details] Patch This needs a rebase after r140686.

Kenneth Rohde Christiansen

Comment 8 2013-01-28 02:04:54 PST

Created attachment 184957 [details] Patch