Bug 106554

Summary:

[Qt] REGRESSION(r137436): It made all inspector tests timeout on developer builds

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Jocelyn Turcotte <jturcotte>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte, ossy, vestbo, vivekg

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79668, 104677

Attachments:

Description	Flags
Patch	hausmann: review+, hausmann: commit-queue-

Csaba Osztrogonác

Reported 2013-01-10 04:59:12 PST

You can easily reprouce it on Ubuntu 11.10 or 12.04 with Tools/Scripts/build-webkit (without CONFIG+=buildbot) I have no idea how is it possible ... but it is a valid bug. http://trac.webkit.org/changeset/137436 only moved qrc_InspectorBackendCommands.o from libWebCore.so to libQt5WebKit.so. Of course it isn't problem on the bots because CONFIG+=buildbot swiches off force_static_libs_as_shared. Additionally it isn't problem on Debian Squeeze, but libs seems similar to me.

Attachments
Patch (3.87 KB, patch) 2013-01-21 05:17 PST, Jocelyn Turcotte	hausmann: review+ hausmann: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2013-01-14 04:03:07 PST

ping?

Jocelyn Turcotte

Comment 2 2013-01-14 05:59:36 PST

Is there any way that libQt5WebKit.so wouldn't be loaded by DumpRenderTree since it binds directly to libQt5WebKitWidgets.so? I can't reproduce it here but if it is the case, it would make sense that the resources aren't accessible.

Jocelyn Turcotte

Comment 3 2013-01-14 06:02:45 PST

(In reply to comment #2) > Is there any way that libQt5WebKit.so wouldn't be loaded by DumpRenderTree since it binds directly to libQt5WebKitWidgets.so? No this doesn't make sense, please ignore. I'll try to boot my VM and see if I can reproduce it.

Jocelyn Turcotte

Comment 4 2013-01-21 05:17:19 PST

Created attachment 183762 [details] Patch

Vivek Galatage

Comment 5 2013-01-24 15:27:16 PST

(In reply to comment #4) > Created an attachment (id=183762) [details] > Patch Works perfectly. Thank you for pointing to this.

Csaba Osztrogonác

Comment 6 2013-01-31 07:15:25 PST

ping review? (sorry, but I don't have time for it now)

Simon Hausmann

Comment 7 2013-01-31 08:00:32 PST

Comment on attachment 183762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183762&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). The ChangeLog here in WebCore should also have an explanation and the "No new tests" line removed.

Vivek Galatage

Comment 8 2013-02-04 22:54:38 PST

Awaiting for this to land :) till then applying above patch manually!

Jocelyn Turcotte

Comment 9 2013-02-05 07:48:30 PST

Committed r141892: <http://trac.webkit.org/changeset/141892>

Note You need to log in before you can comment on or make changes to this bug.