Bug 106174
Summary: | Flattened frames should probably respect padding when calculating their size. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mike West <mkwst> |
Component: | Frames | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, eric, koivisto |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Mike West
RenderFrameBase::layoutWithFlattening doesn't currently handle padding placed on the IFrame element. This is similar to the issues covered in https://bugs.webkit.org/show_bug.cgi?id=106167 and https://bugs.webkit.org/show_bug.cgi?id=90827 for seamless IFrames.
I don't know enough about flattened frames to know whether they _should_ respect padding, but it seems reasonable. WDYT, Eric?
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I believe they should. I dont remember who the original author of flattening was maybe Antti?
Mike West
Unassigning myself; let's be realistic about what I'm actually working on. :/
Ahmad Saleem
Code is gone + tests - https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687