Bug 105820

and I got many "WARNING: Application calling GLX 1.3 function "glXCreateWindow" when GLX 1.3 is not supported! This is an application bug! failed to create drawable" when I tried to run this test locally. I haven't tried it locally with earliear than r138489, so this warning can be independent of this bug.

I'll take a look tomorrow. Please do not roll out.

(In reply to comment #2) > I'll take a look tomorrow. Please do not roll out. Thanks. No, I won't. I promised I won't roll out any patch in my holiday not even the whole world is broken. :)

(In reply to comment #3) > (In reply to comment #2) > > I'll take a look tomorrow. Please do not roll out. > Thanks. No, I won't. I promised I won't roll out any patch > in my holiday not even the whole world is broken. :) Sensible promise :) enjoy your vacation and thanks for notifying about the regression.

I cannot reproduce it locally, and I've tried on several machines; The test works just fine, also with the exact same command line as the one that is timing out on the bot. This has to be a bot issue; Maybe timeout values need to be adjusted. Any help is welcome :)

detailed results on ToT: ----------------------------- $ time run-in-xvfb.sh WebKitBuild/Release/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview Qt at-spi: error getting the accessibility dbus address: "The name org.a11y.Bus was not provided by any .service files" Accessibility DBus not found. Falling back to session bus. ********* Start testing of tst_QGraphicsWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QGraphicsWebView::initTestCase() QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the dummy plugin QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Generic plugin QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Linux plugin PASS : tst_QGraphicsWebView::qgraphicswebview() PASS : tst_QGraphicsWebView::crashOnViewlessWebPages() PASS : tst_QGraphicsWebView::microFocusCoordinates() PASS : tst_QGraphicsWebView::focusInputTypes() PASS : tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl() FAIL! : tst_QGraphicsWebView::widgetsRenderingThroughCache() Compared values are not the same Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(201)] PASS : tst_QGraphicsWebView::windowResizeEvent() PASS : tst_QGraphicsWebView::setPalette(activeBG) PASS : tst_QGraphicsWebView::setPalette(activeFG) PASS : tst_QGraphicsWebView::setPalette(inactiveBG) PASS : tst_QGraphicsWebView::setPalette(inactiveFG) PASS : tst_QGraphicsWebView::renderHints() PASS : tst_QGraphicsWebView::bug57798() PASS : tst_QGraphicsWebView::bug56929() QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined WARNING: Application calling GLX 1.3 function "glXCreateWindow" when GLX 1.3 is not supported! This is an application bug! failed to create drawable WARNING: Application calling GLX 1.3 function "glXCreatePixmap" when GLX 1.3 is not supported! This is an application bug! failed to create drawable WARNING: Application calling GLX 1.3 function "glXQueryDrawable" when GLX 1.3 is not supported! This is an application bug! FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(632)] WARNING: Application calling GLX 1.3 function "glXDestroyPixmap" when GLX 1.3 is not supported! This is an application bug! QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined failed to create drawable failed to create drawable FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(632)] PASS : tst_QGraphicsWebView::cleanupTestCase() Totals: 15 passed, 3 failed, 0 skipped ********* Finished testing of tst_QGraphicsWebView ********* real 3m28.639s user 3m25.081s sys 0m0.464s detailed results on r138488: ----------------------------- $ time run-in-xvfb.sh WebKitBuild/Release/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview Qt at-spi: error getting the accessibility dbus address: "The name org.a11y.Bus was not provided by any .service files" Accessibility DBus not found. Falling back to session bus. ********* Start testing of tst_QGraphicsWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QGraphicsWebView::initTestCase() QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the dummy plugin QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Generic plugin QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Linux plugin PASS : tst_QGraphicsWebView::qgraphicswebview() PASS : tst_QGraphicsWebView::crashOnViewlessWebPages() PASS : tst_QGraphicsWebView::microFocusCoordinates() PASS : tst_QGraphicsWebView::focusInputTypes() PASS : tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl() FAIL! : tst_QGraphicsWebView::widgetsRenderingThroughCache() Compared values are not the same Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(201)] PASS : tst_QGraphicsWebView::windowResizeEvent() PASS : tst_QGraphicsWebView::setPalette(activeBG) PASS : tst_QGraphicsWebView::setPalette(activeFG) PASS : tst_QGraphicsWebView::setPalette(inactiveBG) PASS : tst_QGraphicsWebView::setPalette(inactiveFG) PASS : tst_QGraphicsWebView::renderHints() PASS : tst_QGraphicsWebView::bug57798() PASS : tst_QGraphicsWebView::bug56929() QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined WARNING: Application calling GLX 1.3 function "glXCreateWindow" when GLX 1.3 is not supported! This is an application bug! failed to create drawable WARNING: Application calling GLX 1.3 function "glXCreatePixmap" when GLX 1.3 is not supported! This is an application bug! failed to create drawable WARNING: Application calling GLX 1.3 function "glXQueryDrawable" when GLX 1.3 is not supported! This is an application bug! FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(632)] WARNING: Application calling GLX 1.3 function "glXDestroyPixmap" when GLX 1.3 is not supported! This is an application bug! QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined QWARN : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() QBackingStore::flush() called with non-exposed window, behavior is undefined failed to create drawable failed to create drawable FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(632)] PASS : tst_QGraphicsWebView::cleanupTestCase() Totals: 15 passed, 3 failed, 0 skipped ********* Finished testing of tst_QGraphicsWebView ********* real 0m7.626s user 0m4.204s sys 0m0.332s It seems tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() run for a long time and then fail after r138489.

Simon, shouldn't we simple skip tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() ? I think these tests started to fail long long time ago.

(In reply to comment #7) > Simon, shouldn't we simple skip tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() ? > > I think these tests started to fail long long time ago. I checked the bot history, these tests started to fail after http://trac.webkit.org/changeset/104403 . (1 year ago)

(In reply to comment #8) > (In reply to comment #7) > > Simon, shouldn't we simple skip tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() ? > > > > I think these tests started to fail long long time ago. > > I checked the bot history, these tests started to fail after http://trac.webkit.org/changeset/104403 . (1 year ago) r104402: --------- ********* Start testing of tst_QGraphicsWebView ********* Config: Using QTest library 4.8.0, Qt 4.8.0 PASS : tst_QGraphicsWebView::initTestCase() QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Generic plugin PASS : tst_QGraphicsWebView::qgraphicswebview() PASS : tst_QGraphicsWebView::crashOnViewlessWebPages() PASS : tst_QGraphicsWebView::microFocusCoordinates() PASS : tst_QGraphicsWebView::focusInputTypes() PASS : tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl() PASS : tst_QGraphicsWebView::widgetsRenderingThroughCache() PASS : tst_QGraphicsWebView::windowResizeEvent() PASS : tst_QGraphicsWebView::setPalette() PASS : tst_QGraphicsWebView::renderHints() PASS : tst_QGraphicsWebView::cleanupTestCase() Totals: 11 passed, 0 failed, 0 skipped ********* Finished testing of tst_QGraphicsWebView ********* r104403: --------- ********* Start testing of tst_QGraphicsWebView ********* Config: Using QTest library 4.8.0, Qt 4.8.0 PASS : tst_QGraphicsWebView::initTestCase() QDEBUG : tst_QGraphicsWebView::qgraphicswebview() loaded the Generic plugin PASS : tst_QGraphicsWebView::qgraphicswebview() PASS : tst_QGraphicsWebView::crashOnViewlessWebPages() PASS : tst_QGraphicsWebView::microFocusCoordinates() PASS : tst_QGraphicsWebView::focusInputTypes() PASS : tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl() PASS : tst_QGraphicsWebView::widgetsRenderingThroughCache() PASS : tst_QGraphicsWebView::windowResizeEvent() PASS : tst_QGraphicsWebView::setPalette() PASS : tst_QGraphicsWebView::renderHints() PASS : tst_QGraphicsWebView::bug57798() PASS : tst_QGraphicsWebView::bug56929() FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(633)] FAIL! : tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() 'compareImagesFuzzyPixelCount(target, reference, 0.01)' returned FALSE. () Loc: [/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(633)] PASS : tst_QGraphicsWebView::cleanupTestCase() Totals: 13 passed, 2 failed, 0 skipped ********* Finished testing of tst_QGraphicsWebView *********

( These tests are guarded ENABLE_WEBGL ifdef. )

(In reply to comment #7) > Simon, shouldn't we simple skip tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() ? > > I think these tests started to fail long long time ago. Yes, fully agreed. I don't even see the point in having a software OpenGL fallback altogether and would rather get rid of it. Software OpenGL is best done on the low level using for example mesa-llvmpipe, not on the WebKit/Qt level.

Simon, should we disable or remove these tests? And/or are we interested in this 30x slowdown? + info: These tests introduced in https://trac.webkit.org/changeset/81886/trunk/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp

(In reply to comment #11) > (In reply to comment #7) > > Simon, shouldn't we simple skip tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation() and tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation() ? > > > > I think these tests started to fail long long time ago. > > Yes, fully agreed. > > I don't even see the point in having a software OpenGL fallback altogether and would rather get rid of it. > > Software OpenGL is best done on the low level using for example mesa-llvmpipe, not on the WebKit/Qt level. Do you mean reverting r81886?

ping? API tests are still red with "Failure: timeout occured during testing" error message because of this bug. In this case it's so hard to catch new regressions. And it seems there is a new one. kadam is searching the culprit right now.

Seems to hang in (gdb) bt #0 __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:132 #1 0x00007fffeec2b065 in _L_lock_858 () from /lib/x86_64-linux-gnu/libpthread.so.0 #2 0x00007fffeec2aeba in __pthread_mutex_lock (mutex=0xda5ef0) at pthread_mutex_lock.c:61 #3 0x00007ffff1581e53 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #4 0x00007ffff157ad30 in XGetWindowAttributes () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #5 0x00007ffff659db3c in WebCore::GraphicsSurface::platformPaintToTextureMapper(WebCore::TextureMapper*, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float, WebCore::BitmapTexture*) () from /home/berlin/src/webkit/trunk/WebKitBuild/Release/lib/libQt5WebKit.so.5 #6 0x00007ffff6582db2 in WebCore::GraphicsContext3DPrivate::paintToTextureMapper(WebCore::TextureMapper*, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float, WebCore::BitmapTexture*) () from /home/berlin/src/webkit/trunk/WebKitBuild/Release/lib/libQt5WebKit.so.5 #7 0x00007ffff630e87f in WebCore::TextureMapperLayer::paintSelf(WebCore::TextureMapperPaintOptions const&) () from /home/berlin/src/webkit/trunk/WebKitBuild/Release/lib/libQt5WebKit.so.5

Skipped in http://trac.webkit.org/changeset/141575 to paint the bot a little greener. (I'll look at the other timeouts now)

The QT port is no longer part of WebKit.