Bug 105641

Summary: [CSS Regions] Selecting text through nested regions causes weird and unclearable selection
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109228    
Attachments:
Description Flags
image from the unclearable selection
none
proposed patch hyatt: review+, webkit.review.bot: commit-queue-

Zoltan Horvath
Reported 2012-12-21 10:27:14 PST
If you have a region with a nested region inside what is rendered below the base region and you are trying select text starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.
Attachments
image from the unclearable selection (33.59 KB, image/png)
2012-12-21 10:27 PST, Zoltan Horvath 		no flags
Details
proposed patch (55.97 KB, patch)
2012-12-21 10:35 PST, Zoltan Horvath 		hyatt: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-12-21 10:27:59 PST
Created attachment 180533 [details] image from the unclearable selection
Zoltan Horvath
Comment 2 2012-12-21 10:35:59 PST
Created attachment 180534 [details] proposed patch
WebKit Review Bot
Comment 3 2012-12-21 11:13:13 PST
Comment on attachment 180534 [details] proposed patch Attachment 180534 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15458448 New failing tests: fast/regions/selecting-text-through-different-region-flows.html
Zoltan Horvath
Comment 4 2013-01-07 10:22:05 PST
(In reply to comment #3) > (From update of attachment 180534 [details]) > Attachment 180534 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15458448 > > New failing tests: > fast/regions/selecting-text-through-different-region-flows.html It's just a missing result on that platform. I'm not going to add the result generated by my vmware-cr-linux, since it shows 1px difference compared to the results of the bots for some reason.
Dave Hyatt
Comment 5 2013-01-08 14:24:30 PST
Comment on attachment 180534 [details] proposed patch r=me
WebKit Review Bot
Comment 6 2013-01-08 15:12:38 PST
Comment on attachment 180534 [details] proposed patch Rejecting attachment 180534 [details] from commit-queue. New failing tests: fast/regions/selecting-text-through-different-region-flows.html Full output: http://queues.webkit.org/results/15754446
Zoltan Horvath
Comment 7 2013-01-09 09:31:02 PST
Landed in http://trac.webkit.org/changeset/139197
Note You need to log in before you can comment on or make changes to this bug.