Bug 105494

Summary: [TexMap] Remove ParentChange in TextureMapperLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, kenneth, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110211    
Attachments:
Description Flags
Patch none

Dongseong Hwang
Reported 2012-12-19 21:39:05 PST
ParentChange is useless, because ChildrenChange is enough. In addition, GraphicsLayer uses setParent() method internally.
Attachments
Patch (8.91 KB, patch)
2012-12-19 22:03 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-12-19 22:03:21 PST
Created attachment 180278 [details] Patch
WebKit Review Bot
Comment 2 2012-12-20 13:23:16 PST
Comment on attachment 180278 [details] Patch Clearing flags on attachment: 180278 Committed r138291: <http://trac.webkit.org/changeset/138291>
WebKit Review Bot
Comment 3 2012-12-20 13:23:20 PST
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 4 2013-09-25 06:28:09 PDT
This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children.
Noam Rosenthal
Comment 5 2013-09-25 06:35:19 PDT
(In reply to comment #4) > This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children. Wasn't it committed 9 months ago?
Allan Sandfeld Jensen
Comment 6 2013-09-25 07:03:50 PDT
(In reply to comment #5) > (In reply to comment #4) > > This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children. > > Wasn't it committed 9 months ago? Yes, but after the branch of QtWebKit for 5.0/5.1. And it didn't get cherry-picked because it sounded like a refactoring not a bug-fix. Just venting a bit because I just spend half a week tracking this issue down for a customer.
Note You need to log in before you can comment on or make changes to this bug.