Bug 105256

Summary: Use element.webkitCreateShadowRoot instead of WebKitShadowRoot in PerformanceTests.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: Tools / TestsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63606    
Attachments:
Description Flags
Use element.webkitCreateShadowRoot()
none
Patch for landing none

Hayato Ito
Reported 2012-12-17 23:12:46 PST
WebKitShadowRoot constructor was deleted. We should update the performance tests.
Attachments
Use element.webkitCreateShadowRoot() (6.69 KB, patch)
2012-12-17 23:36 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.12 KB, patch)
2012-12-18 18:27 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-12-17 23:36:17 PST
Created attachment 179885 [details] Use element.webkitCreateShadowRoot()
WebKit Review Bot
Comment 2 2012-12-18 07:54:29 PST
Comment on attachment 179885 [details] Use element.webkitCreateShadowRoot() Rejecting attachment 179885 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: AILED at 24. 1 out of 1 hunk FAILED -- saving rejects to file PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html.rej patching file PerformanceTests/ShadowDOM/MultipleInsertionPoints.html patching file PerformanceTests/ShadowDOM/ShadowReprojection.html patching file PerformanceTests/ShadowDOM/SmallDistributionWithLayout.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Dimitri Gl..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15410168
Hayato Ito
Comment 3 2012-12-18 18:27:06 PST
Created attachment 180072 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-12-18 20:19:49 PST
Comment on attachment 180072 [details] Patch for landing Clearing flags on attachment: 180072 Committed r138108: <http://trac.webkit.org/changeset/138108>
WebKit Review Bot
Comment 5 2012-12-18 20:19:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.