Bug 104770

Summary: REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hayato
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102913    
Attachments:
Description Flags
ROLLOUT of r137408 webkit.review.bot: commit-queue-

WebKit Review Bot
Reported 2012-12-11 23:22:31 PST
http://trac.webkit.org/changeset/137408 broke the build: breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r137408 (234.82 KB, patch)
2012-12-11 23:23 PST, WebKit Review Bot 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-12-11 23:23:26 PST
Created attachment 178976 [details] ROLLOUT of r137408 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2012-12-11 23:31:12 PST
Comment on attachment 178976 [details] ROLLOUT of r137408 Rejecting attachment 178976 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rame.html patching file LayoutTests/fast/js/global-constructors-expected.txt patching file LayoutTests/inspector/elements/shadow-root.html patching file LayoutTests/inspector/elements/update-shadowdom.html patching file LayoutTests/platform/efl/fast/js/global-constructors-expected.txt patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15281379
Hayato Ito
Comment 3 2012-12-11 23:47:47 PST
It seems http://trac.webkit.org/changeset/137421 depends on the r137408. So instead of rolling out the this big patch, it might be reasonable to just recover the constructor part so that we can avoid reverting all existing layout tests. Let me do that. (In reply to comment #2) > (From update of attachment 178976 [details]) > Rejecting attachment 178976 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > rame.html > patching file LayoutTests/fast/js/global-constructors-expected.txt > patching file LayoutTests/inspector/elements/shadow-root.html > patching file LayoutTests/inspector/elements/update-shadowdom.html > patching file LayoutTests/platform/efl/fast/js/global-constructors-expected.txt > patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue > > Full output: http://queues.webkit.org/results/15281379
Hayato Ito
Comment 4 2012-12-11 23:55:40 PST
Committed r137425: <http://trac.webkit.org/changeset/137425>
Note You need to log in before you can comment on or make changes to this bug.