Bug 104687

Summary: check-webkit-style complaining about TestExpectations lines a patch didn't modify
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric, esprehn, halton.huo, hamaji, levin, ojan, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ojan: review+

Dirk Pranke
Reported 2012-12-11 10:55:24 PST
See bug 104462 for context ... check-webkit-style seems to be complaining about errors in TestExpectation lines unrelated to the patch. This is causing the style bot to fail and will block patches in the commit queue. I also saw the error locally when I landed the patch by hand.
Attachments
Patch (3.83 KB, patch)
2012-12-11 12:44 PST, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-11 12:44:56 PST
Created attachment 178853 [details] Patch
Ojan Vafai
Comment 2 2012-12-11 13:29:36 PST
Comment on attachment 178853 [details] Patch In theory we could fix this properly by having both lines involved in a duplicate expectation get a lint error? Then we wouldn't lose any coverage here. We'd still want line filtering on for that though, right? So this patch is correct either way, but a FIXME would be nice. It's going to be a pain to keep the lint-webkitpy step green.
Dirk Pranke
Comment 3 2012-12-11 13:33:11 PST
(In reply to comment #2) > (From update of attachment 178853 [details]) > In theory we could fix this properly by having both lines involved in a duplicate expectation get a lint error? Then we wouldn't lose any coverage here. > Perhaps. A complication would be that you wouldn't want to print both lines to stderr in the lint-test-files case, but we can probably do something. > We'd still want line filtering on for that though, right? So this patch is correct either way, but a FIXME would be nice. It's going to be a pain to keep the lint-webkitpy step green. I think I'll file a bug for the enhancement instead.
Dirk Pranke
Comment 4 2012-12-11 13:42:45 PST
filed https://bugs.webkit.org/show_bug.cgi?id=104712 ; ended up adding a FIXME as well :).
Dirk Pranke
Comment 5 2012-12-11 13:43:02 PST
Committed r137355: <http://trac.webkit.org/changeset/137355>
Note You need to log in before you can comment on or make changes to this bug.