Bug 104259

Summary: Fix webgl-depth-texture.html to match the test expectation
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebGLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, gman, kbr, kenneth, lucas.de.marchi, webkit.review.bot, yael, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 102991    
Attachments:
Description Flags
patch
none
patch none

Kalyan
Reported 2012-12-06 06:51:57 PST
The text expectation for this testcase expects to check for FrameBuffer status after creating the framebuffer.
Attachments
patch (1.80 KB, patch)
2012-12-06 07:22 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
patch (1.80 KB, patch)
2012-12-06 08:09 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2012-12-06 07:22:32 PST
Created attachment 178010 [details] patch
WebKit Review Bot
Comment 2 2012-12-06 07:24:07 PST
Attachment 178010 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kalyan
Comment 3 2012-12-06 07:45:28 PST
Comment on attachment 178010 [details] patch will update a new patch
Kalyan
Comment 4 2012-12-06 08:09:58 PST
Created attachment 178015 [details] patch
Kenneth Russell
Comment 5 2012-12-07 15:03:06 PST
Comment on attachment 178015 [details] patch The basic problem seems to be that Intel's driver reports the framebuffer as complete after adding only the depth or depth/stencil texture, and the test only asserts that the FBO is complete if it was incomplete with just that attachment. The change to the test matches the current expectations for all the ports, so it seems OK. I will take care of upstreaming this change to the Khronos WebGL repo. r=me
WebKit Review Bot
Comment 6 2012-12-07 15:07:50 PST
Comment on attachment 178015 [details] patch Clearing flags on attachment: 178015 Committed r136990: <http://trac.webkit.org/changeset/136990>
WebKit Review Bot
Comment 7 2012-12-07 15:07:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.