Bug 104218

Summary: [Shadow DOM] Implement HTMLShadowElement::olderShadowRoot
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan.autocc, sgrekhov, shinyak, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104346    
Bug Blocks: 63606    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Attachments
Patch (2.09 KB, patch)
2012-12-06 01:46 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2012-12-06 20:27 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.59 KB, patch)
2012-12-11 21:29 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.89 KB, patch)
2012-12-11 23:30 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-12-06 01:46:57 PST
Created attachment 177972 [details] Patch
Shinya Kawanaka
Comment 2 2012-12-06 18:06:39 PST
Comment on attachment 177972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177972&action=review > Source/WebCore/html/shadow/HTMLShadowElement.cpp:98 > + TreeScope* scope = treeScope(); We have to check distribution is finished here.
Shinya Kawanaka
Comment 3 2012-12-06 20:27:46 PST
Created attachment 178145 [details] Patch
Dimitri Glazkov (Google)
Comment 4 2012-12-06 20:55:55 PST
Comment on attachment 178145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178145&action=review > Source/WebCore/html/shadow/HTMLShadowElement.cpp:101 > + document()->updateLayout(); Whoa. I am curious why have to do something so drastic here.
Shinya Kawanaka
Comment 5 2012-12-06 22:25:20 PST
(In reply to comment #4) > (From update of attachment 178145 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178145&action=review > > > Source/WebCore/html/shadow/HTMLShadowElement.cpp:101 > > + document()->updateLayout(); > > Whoa. I am curious why have to do something so drastic here. When <shadow> is in a nested ShadowRoot, we have to ensure distribution of the parent TreeScope recursively... Actually I've just followed HTMLContentElement::getDistributedNodes() though, because I know the above condition. assignedTo() might be calculated by a partial distribution, but I'm not sure yet.
Shinya Kawanaka
Comment 6 2012-12-06 22:37:22 PST
Ah, if <shadow> is not in document tree, distribution won't happen by this code... I think getDistributedNodes() has the same bug. I'll confirm and fix it.
Shinya Kawanaka
Comment 7 2012-12-07 00:13:16 PST
Anyway, we have to fix https://bugs.webkit.org/show_bug.cgi?id=104346 first. This prevents us from fixing this issue.
Shinya Kawanaka
Comment 8 2012-12-11 21:29:58 PST
Created attachment 178959 [details] Patch
Shinya Kawanaka
Comment 9 2012-12-11 21:30:46 PST
This patch can be applied after Bug 104346 is resolved.
Shinya Kawanaka
Comment 10 2012-12-11 23:30:20 PST
Created attachment 178977 [details] Patch
WebKit Review Bot
Comment 11 2012-12-12 00:14:10 PST
Comment on attachment 178977 [details] Patch Clearing flags on attachment: 178977 Committed r137429: <http://trac.webkit.org/changeset/137429>
WebKit Review Bot
Comment 12 2012-12-12 00:14:14 PST
All reviewed patches have been landed. Closing bug.
Shinya Kawanaka
Comment 13 2012-12-18 18:19:54 PST
*** Bug 105269 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.