Bug 103302

Summary: [EFL] Graphics layer edges are sometimes very pixelated
Product: WebKit Reporter: Yael <yael>
Component: Layout and RenderingAssignee: Yael <yael>
Status: RESOLVED FIXED    
Severity: Normal CC: kalyan.kondapally, noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103105    
Attachments:
Description Flags
The issue
none
Patch
noam: review+
Patch
noam: review-, noam: commit-queue-
Patch none

Yael
Reported 2012-11-26 15:06:35 PST
Created attachment 176081 [details] The issue The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html. Reloading a couple of times makes the problem go away.
Attachments
The issue (39.04 KB, image/png)
2012-11-26 15:06 PST, Yael 		no flags
Details
Patch (1.92 KB, patch)
2012-11-26 18:43 PST, Yael 		noam: review+
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2012-11-26 19:09 PST, Yael 		noam: review-
noam: commit-queue-
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2012-11-27 05:06 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2012-11-26 17:41:33 PST
(In reply to comment #0) > Created an attachment (id=176081) [details] > The issue > > The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html. > Reloading a couple of times makes the problem go away. Yes, edges seem to be jagged. For me Reloading didn't make the problem go away. Some other observations: The edges become smooth after I moved the mouse over the box. When we move the mouse over the box, it results in a coloured border being drawn (I guess some kind of debug borders?? ). Interesting thing is that the edges of coloured border drawn at this point seem to be suffering from the same issue as original box borders.
Yael
Comment 2 2012-11-26 18:03:44 PST
Kalyan volunteered to work on this :)
Yael
Comment 3 2012-11-26 18:24:49 PST
(In reply to comment #2) > Kalyan volunteered to work on this :) Taking back, since I found the problem.
Yael
Comment 4 2012-11-26 18:43:17 PST
Created attachment 176142 [details] Patch
Kalyan
Comment 5 2012-11-26 18:58:48 PST
Do we need to set the flag always?? Shouldn't it be enough to set it during texture creation ??
Yael
Comment 6 2012-11-26 19:01:38 PST
(In reply to comment #5) > Do we need to set the flag always?? > > Shouldn't it be enough to set it during texture creation ?? The flag is set on TextureMapper itself, during its own creation.
Yael
Comment 7 2012-11-26 19:09:55 PST
Created attachment 176149 [details] Patch Address comment #5.
Noam Rosenthal
Comment 8 2012-11-26 21:23:16 PST
Comment on attachment 176149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166 > m_textureMapper = TextureMapper::create(); > + static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true); This would crash.
Kenneth Rohde Christiansen
Comment 9 2012-11-27 00:58:06 PST
Comment on attachment 176149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review >> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166 >> + static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true); > > This would crash. Software mode :-)
Yael
Comment 10 2012-11-27 04:58:38 PST
(In reply to comment #9) > (From update of attachment 176149 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review > > >> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166 > >> + static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true); > > > > This would crash. > > Software mode :-) oops :)
Yael
Comment 11 2012-11-27 05:06:20 PST
Created attachment 176239 [details] Patch Address comment #8.
WebKit Review Bot
Comment 12 2012-11-27 06:43:33 PST
Comment on attachment 176239 [details] Patch Clearing flags on attachment: 176239 Committed r135858: <http://trac.webkit.org/changeset/135858>
WebKit Review Bot
Comment 13 2012-11-27 06:43:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.