Bug 103271

Summary: [EFL][Qt][WK2] Tiles not always painted
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: New BugsAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cdumez, jesus, jturcotte, jussi.kukkonen, laszlo.gombos, mikhail.pozdnyakov, noam, ostap73, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101288, 103105    
Attachments:
Description Flags
Issue
none
Test case
none
patch none

Kenneth Rohde Christiansen
Reported 2012-11-26 10:15:31 PST
Run https://bug-103081-attachments.webkit.org/attachment.cgi?id=175962 with WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS=1 Resize window to be smaller than one tile. Now resize to be bigger than 1 tile in height and 2 tiles in width. result: third tile row in in x-direction is not there.
Attachments
Issue (53.67 KB, image/png)
2012-11-26 10:16 PST, Kenneth Rohde Christiansen 		no flags
Details
Test case (5.02 KB, text/html)
2012-11-27 06:09 PST, Kenneth Rohde Christiansen 		no flags
Details
patch (2.02 KB, patch)
2012-11-27 08:40 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-11-26 10:16:54 PST
Created attachment 176026 [details] Issue
Kenneth Rohde Christiansen
Comment 2 2012-11-27 03:32:46 PST
To be able to easily reproduce, add the follwing patch: @@ -377,6 +377,8 @@ void TiledBackingStore::computeCoverAndKeepRect(const IntRect& visibleRect, IntR coverRect = visibleRect; keepRect = visibleRect; + return; + The bug is in @@ -196,6 +196,8 @@ void PageViewportController::didChangeViewportSize(const FloatSize& newSize) // it can resize the content accordingly. m_webPageProxy->setViewportSize(roundedIntSize(newSize)); syncVisibleContents(); } Which sync'ed the visible content before the new fixed layout size has been applied in the web process.
Kenneth Rohde Christiansen
Comment 3 2012-11-27 06:09:29 PST
Created attachment 176251 [details] Test case
Mikhail Pozdnyakov
Comment 4 2012-11-27 08:40:57 PST
Created attachment 176274 [details] patch
Kenneth Rohde Christiansen
Comment 5 2012-11-27 08:42:48 PST
Comment on attachment 176274 [details] patch Didn't this fix some layout tests?
Jocelyn Turcotte
Comment 6 2012-11-27 08:53:12 PST
Comment on attachment 176274 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=176274&action=review > Source/WebKit2/ChangeLog:8 > + The problem turned up because visible content was synchromized before the new fixed synchromized -> syncronized
WebKit Review Bot
Comment 7 2012-11-27 09:03:26 PST
Comment on attachment 176274 [details] patch Clearing flags on attachment: 176274 Committed r135864: <http://trac.webkit.org/changeset/135864>
WebKit Review Bot
Comment 8 2012-11-27 09:03:31 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 9 2012-12-04 05:35:29 PST
I spent a while using git bisect and it turns out that this patch seems to be causing failures in several css-sticky test cases. Try for example the following: WebKitBuild/Debug/bin/MiniBrowser LayoutTests/fast/css/sticky/inflow-sticky.html The output will be wrong (no blue stripe). Then try to resize the window, it will repaint and the blue stripe will appear. The output will then match the one in the -expected.html.
Chris Dumez
Comment 10 2012-12-04 06:39:25 PST
You can also test http://html5-demos.appspot.com/static/css/sticky.html You'll see that the sticky element does not behave as expected. It gets repositioned only when you resize the window. It is pretty broken.
Note You need to log in before you can comment on or make changes to this bug.