Bug 103184

Summary: Put computed style 'font-family' values in the CSSValuePool.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED INVALID    
Severity: Normal CC: cmarcelo, kling, macpherson, menard, ojan, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103196, 103218    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2012-11-24 11:32:25 PST
They're already cached in the parsing stage so there's no sense in constructing new objects when exposing them through CSSComputedStyleDeclaration.
Attachments
Patch (2.49 KB, patch)
2012-11-24 11:39 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-11-24 11:39:47 PST
Created attachment 175862 [details] Patch
WebKit Review Bot
Comment 2 2012-11-24 12:32:12 PST
Comment on attachment 175862 [details] Patch Clearing flags on attachment: 175862 Committed r135656: <http://trac.webkit.org/changeset/135656>
WebKit Review Bot
Comment 3 2012-11-24 12:32:15 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2012-11-25 00:39:56 PST
(In reply to comment #2) > (From update of attachment 175862 [details]) > Clearing flags on attachment: 175862 > > Committed r135656: <http://trac.webkit.org/changeset/135656> It made 2 tests crash on Qt, see https://bugs.webkit.org/show_bug.cgi?id=103196 for details.
WebKit Review Bot
Comment 5 2012-11-25 23:40:59 PST
Re-opened since this is blocked by bug 103218
Andreas Kling
Comment 6 2014-08-19 16:13:12 PDT
This is not a valid optimization, since compute style values are exposed in CSSOM.
Note You need to log in before you can comment on or make changes to this bug.