Bug 102942

Summary: [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, jturcotte, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76773    
Attachments:
Description Flags
Patch vestbo: review+

Simon Hausmann
Reported 2012-11-21 07:34:14 PST
The fact that QT_DLL is required for the correct import/export macros breaks the build of applications against QtWebKit when using cmake. See also https://bugreports.qt-project.org/browse/QTBUG-28043
Attachments
Patch (4.47 KB, patch)
2012-11-21 07:44 PST, Simon Hausmann 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-11-21 07:44:28 PST
Created attachment 175445 [details] Patch
Tor Arne Vestbø
Comment 2 2012-11-21 08:17:31 PST
Comment on attachment 175445 [details] Patch lgtm
Simon Hausmann
Comment 3 2012-11-23 03:30:35 PST
Committed r135585: <http://trac.webkit.org/changeset/135585>
Note You need to log in before you can comment on or make changes to this bug.