Bug 101827

Summary: Allow ports to decide whether an image should be directly composited
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: dongseong.hwang, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Noam Rosenthal
Reported 2012-11-09 19:55:59 PST
For coordinated-graphics (Qt/EFL), it doesn't make sense to directly composite huge images or animated GIFs. Since directly composited is an optional optimization, it would make sense to let the GraphicsLayer implementation make the decision about the image direct compositing strategy, the same way it decides whether an animation is accelerated.
Attachments
Patch (5.77 KB, patch)
2012-11-09 20:03 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.66 KB, patch)
2012-11-09 20:15 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-11-09 20:03:32 PST
Created attachment 173426 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-11-09 20:09:39 PST
Comment on attachment 173426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173426&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:342 > + virtual bool canDirectlyCompositeImage(Image*) const { return true; } I think shouldDirectlyCompositeImage() would be slightly better.
Noam Rosenthal
Comment 3 2012-11-09 20:15:50 PST
Created attachment 173427 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-11-09 20:49:39 PST
Comment on attachment 173427 [details] Patch for landing Clearing flags on attachment: 173427 Committed r134147: <http://trac.webkit.org/changeset/134147>
WebKit Review Bot
Comment 5 2012-11-09 20:49:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.