Bug 101702

Summary: [Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101171    
Attachments:
Description Flags
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-11-08 21:32:19 PST
We would like to remove shadowPseudoId, and use pseudo() instead.
Attachments
Patch (2.49 KB, patch)
2012-11-08 21:47 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.38 KB, patch)
2012-11-08 23:03 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-08 21:47:07 PST
Created attachment 173200 [details] Patch
Hajime Morrita
Comment 2 2012-11-08 22:50:52 PST
Comment on attachment 173200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173200&action=review > Source/WebCore/html/track/TextTrackCue.h:57 > + box->setPseudo(textTrackCueBoxShadowPseudoId()); Can we do this in the constructor?
Shinya Kawanaka
Comment 3 2012-11-08 23:03:49 PST
Created attachment 173211 [details] Patch for landing
Shinya Kawanaka
Comment 4 2012-11-08 23:04:26 PST
(In reply to comment #2) > (From update of attachment 173200 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173200&action=review > > > Source/WebCore/html/track/TextTrackCue.h:57 > > + box->setPseudo(textTrackCueBoxShadowPseudoId()); > > Can we do this in the constructor? Done.
WebKit Review Bot
Comment 5 2012-11-08 23:28:41 PST
Comment on attachment 173211 [details] Patch for landing Clearing flags on attachment: 173211 Committed r134020: <http://trac.webkit.org/changeset/134020>
WebKit Review Bot
Comment 6 2012-11-08 23:28:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.