Bug 101364

Summary: [CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101220, 57312    
Attachments:
Description Flags
Patch none

Andrei Bucur
Reported 2012-11-06 09:39:19 PST
Three tests started failing after sub-pixel layout started failing after sub-pixel layout was enabled on Mac: LayoutTests/fast/regions/float-pushed-width-change.html LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html LayoutTests/fast/regions/render-region-renderer.html Fix the tests or the issues in code that caused the failings.
Attachments
Patch (3.33 KB, patch)
2012-11-06 10:30 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-11-06 10:28:23 PST
These are reference tests, which suggests that the references are not really doing layout the same way as the actual test. I'm curious about how other platforms that enable SUBPIXEL_LAYOUT handle this.
Andrei Bucur
Comment 2 2012-11-06 10:30:32 PST
Created attachment 172612 [details] Patch
WebKit Review Bot
Comment 3 2012-11-06 11:19:02 PST
Comment on attachment 172612 [details] Patch Clearing flags on attachment: 172612 Committed r133648: <http://trac.webkit.org/changeset/133648>
WebKit Review Bot
Comment 4 2012-11-06 11:19:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.