Bug 101145

Summary:

Renamed ...InlineMethods.h files to ...Inlines.h

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, dino, eric.carlson, eric, feature-media-reviews, ggaren, japhet, levin+threading, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

98606, 101127

Bug Blocks:

Attachments:

Description	Flags
the patch.	none
Updated patch.	none
svn up'ed again.	none
Removed file that has been obsoleted by other changes during the svn up's.	ggaren: review+

Mark Lam

Reported 2012-11-03 00:10:05 PDT

Renamed inline header files from ...InlineMethods.h to ...Inlines.h. There are no semantic changes, only renames.

Attachments
the patch. (275.35 KB, patch) 2012-11-03 01:02 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Updated patch. (253.35 KB, patch) 2012-11-08 16:24 PST, Mark Lam	no flags	Details Formatted Diff Diff
svn up'ed again. (253.33 KB, patch) 2012-11-08 16:48 PST, Mark Lam	no flags	Details Formatted Diff Diff
Removed file that has been obsoleted by other changes during the svn up's. (252.22 KB, patch) 2012-11-08 17:23 PST, Mark Lam	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2012-11-03 01:02:21 PDT

Created attachment 172212 [details] the patch. The patch has no functionality changes. Only renamed the relevant inline header, and fixed up all the #includes to reference the new names. Also fixed up the #include order in 5 files to keep the style checker happy. Going to run the patch thru the EWS bots first. Will submit for review if it passes the builds on all bots.

WebKit Review Bot

Comment 2 2012-11-03 01:06:10 PDT

Attachment 172212 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 Source/JavaScriptCore/heap/MarkStackInlines.h:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/JavaScriptCore/heap/MarkStackInlines.h:47: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 83 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 3 2012-11-03 01:12:05 PDT

(In reply to comment #2) > Attachment 172212 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 > Source/JavaScriptCore/heap/MarkStackInlines.h:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > Source/JavaScriptCore/heap/MarkStackInlines.h:47: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] > Total errors found: 3 in 83 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. These were pre-existing conditions in the files before I renamed them. The 2 lines in MarkStackInlines.h are just spaces in empty lines. I will remove them before I commit. On the other hand, JSValueInlines.h has indentation for all the inline methods in the file. To fix this, I will have to change the indentation of the entire file. So, I'll just leave it as is instead.

Mark Lam

Comment 4 2012-11-05 10:52:18 PST

Will wait for http://webkit.org/b/98606 and http://webkit.org/b/101127 to minimize merge complications.

Mark Lam

Comment 5 2012-11-08 16:24:23 PST

Created attachment 173144 [details] Updated patch.

Mark Lam

Comment 6 2012-11-08 16:48:11 PST

Created attachment 173147 [details] svn up'ed again.

Mark Lam

Comment 7 2012-11-08 17:23:01 PST

Created attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's.

WebKit Review Bot

Comment 8 2012-11-08 17:27:13 PST

Attachment 173157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 9 2012-11-08 17:28:43 PST

Comment on attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's. The style error came from the file I renamed. Will not fix it in this patch so as to keep the change minimal and restricted to this renaming task. Ready for a review now.

Geoffrey Garen

Comment 10 2012-11-08 18:51:57 PST

Comment on attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's. r=me Please make sure to watch the builders when this lands.

Mark Lam

Comment 11 2012-11-08 19:05:05 PST

Landed in r133995: <http://trac.webkit.org/changeset/133995>.

Note You need to log in before you can comment on or make changes to this bug.