Bug 100962

Summary: [EFL][WK2] Make File Chooser dialog modal in MiniBrowser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, naginenis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100822    
Attachments:
Description Flags
Patch
none
Revised patch
none
Revised patch none

Chris Dumez
Reported 2012-11-01 08:42:52 PDT
Bug 100822 introduced a File chooser dialog in MiniBrowser. However, the new dialog is not modal which is not great for user experience and may lead to problems when closing the main window file the file chooser is open.
Attachments
Patch (1.61 KB, patch)
2012-11-01 09:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Revised patch (2.53 KB, patch)
2012-11-01 12:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Revised patch (3.10 KB, patch)
2012-11-01 12:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-11-01 09:08:27 PDT
Created attachment 171867 [details] Patch
Chris Dumez
Comment 2 2012-11-01 09:39:25 PDT
Comment on attachment 171867 [details] Patch Still have a problem with several windows. I need to fix it.
Chris Dumez
Comment 3 2012-11-01 12:00:36 PDT
Created attachment 171903 [details] Revised patch Fix patch so that the file picker is closed when its parent window is destroyed.
Chris Dumez
Comment 4 2012-11-01 12:35:54 PDT
Created attachment 171909 [details] Revised patch Unregister parent deletion callback when the file chooser dialog is destroyed to avoid double-free.
Sudarsana Nagineni (babu)
Comment 5 2012-11-01 23:03:33 PDT
Comment on attachment 171909 [details] Revised patch LGTM.
WebKit Review Bot
Comment 6 2012-11-01 23:29:27 PDT
Comment on attachment 171909 [details] Revised patch Clearing flags on attachment: 171909 Committed r133267: <http://trac.webkit.org/changeset/133267>
WebKit Review Bot
Comment 7 2012-11-01 23:29:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.