Bug 100822

Summary: [EFL][WK2] Add File Chooser dialog support to MiniBrowser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100818, 100962    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-10-31 00:21:50 PDT
MiniBrowser should show a file chooser dialog when the user click on an input element of type "file".
Attachments
Patch (4.03 KB, patch)
2012-11-01 06:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-11-01 06:29:31 PDT
Created attachment 171829 [details] Patch
WebKit Review Bot
Comment 2 2012-11-01 07:18:05 PDT
Comment on attachment 171829 [details] Patch Clearing flags on attachment: 171829 Committed r133163: <http://trac.webkit.org/changeset/133163>
WebKit Review Bot
Comment 3 2012-11-01 07:18:10 PDT
All reviewed patches have been landed. Closing bug.
Sudarsana Nagineni (babu)
Comment 4 2012-11-01 08:31:33 PDT
Comment on attachment 171829 [details] Patch I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash.
Chris Dumez
Comment 5 2012-11-01 08:33:50 PDT
(In reply to comment #4) > (From update of attachment 171829 [details]) > I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash. Good point babu. I have to admit I did not try that. I'll check now.
Note You need to log in before you can comment on or make changes to this bug.