Bug 100324

Summary:

Implement css-conditional's CSS.supports()

Product:

WebKit

Reporter:

Paul Irish <paulirish>

Component:

CSS

Assignee:

Pablo Flouret <pf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, cmarcelo, dglazkov, ericbidelman, glenn, gtk-ews, gustavo, gyuyoung.kim, haraken, japhet, koivisto, macpherson, menard, ojan.autocc, ojan, peter, peter+ews, pf, philn, rakuco, rniwa, syoichi, tabatkins, webkit-ews, webkit.review.bot, xan.lopez, zan

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

134358

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	koivisto: review+, koivisto: commit-queue-
GTK build fix	none
Patch for landing	webkit.review.bot: commit-queue-
Patch for landing	none

Paul Irish

Reported 2012-10-24 21:20:27 PDT

Bug 86146 took care of @supports, but the JS api was implemented in Opera and FIrefox as well. It was previously supportsCSS() but has now shifted to CSS.supports(). http://dev.w3.org/csswg/css3-conditional/#the-csssupportsrule-interface

Attachments
Patch (45.96 KB, patch) 2012-11-01 14:46 PDT, Pablo Flouret	no flags	Details Formatted Diff Diff
Patch (47.89 KB, patch) 2012-11-02 15:58 PDT, Pablo Flouret	no flags	Details Formatted Diff Diff
Patch (49.64 KB, patch) 2013-01-22 17:29 PST, Pablo Flouret	no flags	Details Formatted Diff Diff
Patch (49.68 KB, patch) 2013-01-23 11:17 PST, Pablo Flouret	no flags	Details Formatted Diff Diff
Patch (49.77 KB, patch) 2013-01-23 17:00 PST, Pablo Flouret	koivisto: review+ koivisto: commit-queue-	Details Formatted Diff Diff
GTK build fix (1.80 KB, patch) 2013-02-05 02:49 PST, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (52.79 KB, patch) 2013-02-05 11:17 PST, Pablo Flouret	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch for landing (51.82 KB, patch) 2013-02-12 11:10 PST, Pablo Flouret	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Pablo Flouret

Comment 1 2012-10-25 16:41:19 PDT

What went into Firefox? I can't see either supportsCSS or CSS.supports in my nightly. Are FF and Opera changing names soon or should a prefix be used here (boo)? How happy is everyone with the new name?

Glenn Adams

Comment 2 2012-10-26 06:30:45 PDT

It's pretty early to commit to this Paul. I don't sense the CSS WG has concluded its thinking; furthermore, I wonder if this should be handled by the normal prefixing rules, i.e., as WebkitCSS, until the WG has reached a consensus about unprefixing.

Tab Atkins

Comment 3 2012-10-26 07:20:50 PDT

(In reply to comment #2) > It's pretty early to commit to this Paul. I don't sense the CSS WG has concluded its thinking; furthermore, I wonder if this should be handled by the normal prefixing rules, i.e., as WebkitCSS, until the WG has reached a consensus about unprefixing. I disagree. Nobody's brought up anything further on the matter since we put it into the spec; the only thing that's been delaying Last Call is our issues around the handling syntax errors in @supports. Once we hit Last Call (which will happen next week at TPAC), we'll only be a few weeks to CR, which is a guaranteed "unprefix" event. Implementing it a month early, when it's not going to hit public before CR, and when everyone else is unprefixing, is fine. So, Pablo, do it without a prefix.

Pablo Flouret

Comment 4 2012-11-01 14:46:14 PDT

Created attachment 171936 [details] Patch

Pablo Flouret

Comment 5 2012-11-01 14:52:58 PDT

Comment on attachment 171936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171936&action=review window.CSS is a glorified namespace so far, i'm not sure if there's a better way right now to handle, bindings-wise, what's effectively a bunch of static methods. Also, is it defined in any spec yet (Tab?). > Source/WebCore/css/DOMWindowCSS.idl:32 > +[ > + InterfaceName=CSS > +] interface DOMWindowCSS { Should this one be conditional on CSS3_CONDITIONAL_RULES for now? > Source/WebCore/page/DOMWindow.h:271 > + DOMWindowCSS* cSS(); The funky casing is due to the CodeGenerator uses WK_lcfirst for the method call, should i add an exception there or is this fine?

Early Warning System Bot

Comment 6 2012-11-01 15:02:06 PDT

Comment on attachment 171936 [details] Patch Attachment 171936 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14681075

kov's GTK+ EWS bot

Comment 7 2012-11-01 15:04:23 PDT

Comment on attachment 171936 [details] Patch Attachment 171936 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14663671

Early Warning System Bot

Comment 8 2012-11-01 15:04:36 PDT

Comment on attachment 171936 [details] Patch Attachment 171936 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14670623

Build Bot

Comment 9 2012-11-01 18:02:19 PDT

Comment on attachment 171936 [details] Patch Attachment 171936 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14678669

Tab Atkins

Comment 10 2012-11-02 07:00:53 PDT

(In reply to comment #5) > (From update of attachment 171936 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171936&action=review > > window.CSS is a glorified namespace so far, i'm not sure if there's a better way right now to handle, bindings-wise, what's effectively a bunch of static methods. Also, is it defined in any spec yet (Tab?). It's in the obvious spec, in the obvious place. ^_^ http://dev.w3.org/csswg/css3-conditional/#the-css-interface > > Source/WebCore/css/DOMWindowCSS.idl:32 > > +[ > > + InterfaceName=CSS > > +] interface DOMWindowCSS { > > Should this one be conditional on CSS3_CONDITIONAL_RULES for now? Probably, yeah. > > Source/WebCore/page/DOMWindow.h:271 > > + DOMWindowCSS* cSS(); > > The funky casing is due to the CodeGenerator uses WK_lcfirst for the method call, should i add an exception there or is this fine? I suspect you'll want an exception there, just because it reads so badly.

Pablo Flouret

Comment 11 2012-11-02 15:58:00 PDT

Created attachment 172164 [details] Patch

Pablo Flouret

Comment 12 2013-01-22 17:29:34 PST

Created attachment 184091 [details] Patch Rebased.

Early Warning System Bot

Comment 13 2013-01-22 17:39:21 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16065210

Early Warning System Bot

Comment 14 2013-01-22 17:44:25 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16037899

WebKit Review Bot

Comment 15 2013-01-22 18:00:00 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16067096

Peter Beverloo (cr-android ews)

Comment 16 2013-01-22 18:18:32 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16033951

EFL EWS Bot

Comment 17 2013-01-22 18:37:31 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16036915

Build Bot

Comment 18 2013-01-22 19:21:31 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16035952

Build Bot

Comment 19 2013-01-22 19:45:06 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16063332

kov's GTK+ EWS bot

Comment 20 2013-01-22 19:53:51 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16067146

Build Bot

Comment 21 2013-01-22 20:15:24 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16040976

Build Bot

Comment 22 2013-01-22 21:41:53 PST

Comment on attachment 184091 [details] Patch Attachment 184091 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16065316

Pablo Flouret

Comment 23 2013-01-23 11:17:40 PST

Created attachment 184268 [details] Patch

Build Bot

Comment 24 2013-01-23 15:44:27 PST

Comment on attachment 184268 [details] Patch Attachment 184268 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16083341

Build Bot

Comment 25 2013-01-23 15:58:29 PST

Comment on attachment 184268 [details] Patch Attachment 184268 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16083340

Pablo Flouret

Comment 26 2013-01-23 17:00:09 PST

Created attachment 184354 [details] Patch

Antti Koivisto

Comment 27 2013-02-04 10:54:51 PST

Comment on attachment 184354 [details] Patch r=me with gtk build fixed

Zan Dobersek

Comment 28 2013-02-05 02:48:45 PST

(In reply to comment #27) > (From update of attachment 184354 [details]) > r=me with gtk build fixed Thank you! I've checked the build failure and I'll append the changes needed for the GTK build to pass. I'd still like to request that you upload the updated reviewed patch again so the EWS can confirm the fix is indeed OK if it's not too much of a hassle for you.

Zan Dobersek

Comment 29 2013-02-05 02:49:30 PST

Created attachment 186587 [details] GTK build fix Should fix the GTK build failure.

Pablo Flouret

Comment 30 2013-02-05 10:23:40 PST

(In reply to comment #28) > (In reply to comment #27) > > (From update of attachment 184354 [details] [details]) > > r=me with gtk build fixed > > Thank you! > > I've checked the build failure and I'll append the changes needed for the GTK build to pass. I'd still like to request that you upload the updated reviewed patch again so the EWS can confirm the fix is indeed OK if it's not too much of a hassle for you. Oh, cool! I'll post a new patch, thanks!

Pablo Flouret

Comment 31 2013-02-05 11:17:55 PST

Created attachment 186664 [details] Patch for landing

Pablo Flouret

Comment 32 2013-02-05 13:11:29 PST

Green all around :-)

WebKit Review Bot

Comment 33 2013-02-12 10:51:56 PST

Comment on attachment 186664 [details] Patch for landing Rejecting attachment 186664 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 186664, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: s). patching file LayoutTests/platform/qt/TestExpectations patching file LayoutTests/platform/win/TestExpectations Hunk #1 succeeded at 2409 (offset -3 lines). patching file LayoutTests/platform/wincairo/TestExpectations Hunk #1 succeeded at 2908 (offset -2 lines). patching file LayoutTests/platform/wk2/TestExpectations Hunk #1 succeeded at 329 (offset -13 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16522305

Pablo Flouret

Comment 34 2013-02-12 11:10:02 PST

Created attachment 187902 [details] Patch for landing Rebased.

WebKit Review Bot

Comment 35 2013-02-13 05:46:44 PST

Comment on attachment 187902 [details] Patch for landing Clearing flags on attachment: 187902 Committed r142739: <http://trac.webkit.org/changeset/142739>

Note You need to log in before you can comment on or make changes to this bug.